(Starling) PickerList no longer dispatches Event.CHANGE

Khaosk

I'm not sure if this was due to an SDK change or what, but all of my PickerLists stopped worked. When a PickerList is opened, none of the listed options react to mouse events. I've tried changing the popupContentManager, but the CHANGE event never gets dispatched no matter what.

I know development has kind of stopped on this side, but can someone think of a hack I can throw in to make this work again?

Khaosk

This is across all platforms, mobile and PC. Not sure how to even start debugging this, I'm close to just quickly rolling my own replacement.

joshtynjala

Unfortunately, I was not able to reproduce this issue. The following code is working for me.

var list:PickerList = new PickerList();
list.dataProvider = new ArrayCollection([
	{label: "One"},
	{label: "Two"},
	{label: "Three"},
]);
list.popUpContentManager = new DropDownPopUpContentManager();
list.addEventListener(Event.CHANGE, function(event:Event):void
{
	trace("change");
});
this.addChild(list);

Are you using a custom item renderer? Which IPopUpContentManager implementations did you try?

Note that if you use BottomDrawerPopUpContentManager, Event.CHANGE won't be dispatched until the pop-up closes.

Khaosk

I can confirm your example code works for me too, just not in my game. I was using a custom item renderer, but after removing all the custom stuff it still wasn't working. I tried the 3 normal popup content managers. I ended putting this in my custom item renderer.

renderer.addEventListener(TouchEvent.TOUCH, function(e:TouchEvent):void
				 {
					 var touch:Touch = e.getTouch(renderer);
					 if (touch && touch.phase == TouchPhase.ENDED)
					 {
						list.selectedIndex = renderer.index;
						list.closeList();
					 }
				 });

After that it worked fine. Shrug.

joshtynjala

With a custom item renderer, you probably want to use the TapToTrigger and TapToSelect utilities.

TapToTrigger makes the custom item renderer dispatch Event.TRIGGER when it is clicked/tapped, which is what the PickerList listens for to determine when the pop-up list needs to close.

TapToSelect toggles the item renderer's isSelected property when the item renderer is clicked/tapped.

This stuff does not happen by default (at least not in the Starling version), so custom item renderers almost always need these utilities.

You also need be sure that changing the isSelected property setter causes Event.CHANGE to be dispatched by your custom item renderer. The List component depends on this event to detect when an item renderer is selected.

Khaosk

I'm just changing the DefaultListItemRenderer, so I assume those should be set. I'll keep looking into it, thanks for the info!

var renderer:DefaultListItemRenderer = new DefaultListItemRenderer();
				renderer.labelField = "text";
				renderer.defaultSkin = new Image(DisplayH.textureList);
			
				renderer.addEventListener(TouchEvent.TOUCH, function(e:TouchEvent):void
				 {
					 var touch:Touch = e.getTouch(renderer);
					 if (touch && touch.phase == TouchPhase.ENDED)
					 {
						list.selectedIndex = renderer.index;
						list.closeList();
					 }
				 });